Review Request 109015: Cleanup Places Panel context menus

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109015/#review27677
-----------------------------------------------------------


Thanks for the patch!

Even though I agree that many of your ideas make a lot of sense, I see the problem that this patch makes the context menu in Dolphin's Places Panel and the context menu in KFilePlacesView, which is used in the "File" dialog of all KDE applications and a few other places, behave quite differently. At the moment, they are quite similar (except for the grouping in Dolphin and the different approach to icon size resizing). I'm not a usability expert, but I think that this would not be a good idea. Therefore, I would suggest to propose analogous changes in KFilePlacesView and try to keep it consistent.

Some more ideas about the different changes:

 - Removing the device name in all the entries

Very good idea IMHO.

 - Moving "Open in a new tab" to the top like in most other places in KDE (Unmount and Empty Trash are always above because they're more important) 

Looks good.

 - Moving Icon Size to the global context menu rather than the item context menu where it made no sense from a context perspective

Actually, I think I would expect to be able to configure the Icon Size by right-clicking the icon itself. Also the KToolBar context menu (which was my motivation to resolve the "Icon Size" issue in this way) shows the "Icon Size" submenu when clicking an item. Should we not aim for consistency?

 - Removed "Unlock panels" from item context menu (also no "contextual" thing)
 - Removed "Add Entry" from item context menu
 - Removed "Show all entries" from item context menu

Probably makes sense, but

a) People might be used to being able to invoke these actions by right-clicking anywhere in the Panel,
b) If you hide an entry accidentally, you cannot revert that action quickly by right-clicking the same location, and it might not be obvious how to do it properly,
b) I share Christoph's concern that it might not be obvious that these options exist at all if the Panel is "almost full", and
c) (most importantly) this would create a big "usability diff" between the Places Panel and KFilePlacesView, as I said already.


- Frank Reininghaus


On Feb. 18, 2013, 6:43 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109015/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 6:43 p.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This patch cleans up the places panel context menus by:
>  - Removing the device name in all the entries, it just distracts and every … single … entry has them. (It is debateable whether that title is needed or fitting, I am not a huge fan of these)
>  - Moving "Open in a new tab" to the top like in most other places in KDE (Unmount and Empty Trash are always above because they're more important) 
>  - Moving Icon Size to the global context menu rather than the item context menu where it made no sense from a context perspective
>  - Removed "Unlock panels" from item context menu (also no "contextual" thing)
>  - Removed "Add Entry" from item context menu
>  - Removed "Show all entries" from item context menu
> 
> See screenshot for direct comparison between all changed context menus.
> Of course this makes Dolphin's places panel drift even further away from generic kdelibs places panel but they so different already …
> 
> 
> This addresses bug 310764.
>     http://bugs.kde.org/show_bug.cgi?id=310764
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 
>   dolphin/src/panels/places/placespanel.cpp e23732c 
> 
> Diff: http://git.reviewboard.kde.org/r/109015/diff/
> 
> 
> Testing
> -------
> 
> Editing still works, hiding/showing items, showing all, changing icon size, emptying trash, mounting/unmounting.
> 
> 
> File Attachments
> ----------------
> 
> Comparison (left old, right new)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/cleanupplaces.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130218/7998afb2/attachment.htm>