Review Request 108989: Fix crash when clicking an action in the Places Panel context menu, and the corresponding device has been removed while the context menu was open

Frank Reininghaus frank78ac at googlemail.com
Sun Feb 17 10:16:57 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108989/
-----------------------------------------------------------

Review request for Dolphin.


Description
-------

After a context menu action has been clicked which needs to access a device, we have to check if the position of the device is still the same and adjust its index accordingly. More importantly, we also have to verify if the device is still there to prevent a crash.


This addresses bug 315298.
    http://bugs.kde.org/show_bug.cgi?id=315298


Diffs
-----

  dolphin/src/panels/places/placespanel.cpp 919f2ed 

Diff: http://git.reviewboard.kde.org/r/108989/diff/


Testing
-------

Cannot reproduce the crash any more. Could not see any regressions so far.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130217/482346fb/attachment.htm>


More information about the kfm-devel mailing list