Review Request 108667: Let dolphin look at the firstDayOfWeek as set up in the system's locale settings.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108667/#review27373
-----------------------------------------------------------


> I changed the behavior of the previous month because you found the old one a bug.

I don't get it. I actually thought that I had made clear what I considered a bug, namely, that the grouping by weeks is done differently in the current month and in the last month, see the screenshot http://ompldr.org/vaGN3ag/testi.png, which has two different 'Last Week' groups separated by a few 'single day' groups. I did *not* say that grouping the last month into different weeks (which is what your patch removes) is buggy.

As I said, I'm OK with the patch minus the 'last month' changes being committed to master. I'm not sure if removing the different groups in the last month is a good idea. Does anyone else here think that these groups cause confusion?

- Frank Reininghaus


On Feb. 12, 2013, 3:25 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108667/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 3:25 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> When sorting files by date, dolphin doesn't note the user's system settings. There it's possible to define another first day of week instead of the default (f.e. Sunday instead of Monday).
> This patch fixes this issue.
> 
> 
> This addresses bug 181337.
>     http://bugs.kde.org/show_bug.cgi?id=181337
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp a763b3f 
> 
> Diff: http://git.reviewboard.kde.org/r/108667/diff/
> 
> 
> Testing
> -------
> 
> Performed the steps described in comment #3 of the bug report which I won't post here again.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130213/5d36449b/attachment.htm>