Review Request 108858: Fix blinking when moving the mouse over an hidden item

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108858/#review27137
-----------------------------------------------------------

Ship it!


Thanks Aurélien, very good investigation! Please push to 4.10 (I think would replace "1." by "1.0" for consistency, but it doesn't matter much).

BTW, thanks Emmanuel for finding the right bug report!

- Frank Reininghaus


On Feb. 8, 2013, 4:57 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108858/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 4:57 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Fix blinking when moving the mouse over an hidden item
> 
> The opacity of the unhovered pixmap must be gradually reduced while animating otherwise the alpha channel saturates.
> 
> Note that this bug is mostly visible on hidden items because their pixels are not fully opaque, but could potentially affect "normal" files if their icons have translucent areas.
> 
> 
> This addresses bug 299371.
>     http://bugs.kde.org/show_bug.cgi?id=299371
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp f3414e3f271b0dd42c4bebd67cfa74f9e0d2e999 
> 
> Diff: http://git.reviewboard.kde.org/r/108858/diff/
> 
> 
> Testing
> -------
> 
> Started Dolphin in Icon view mode (bug is more visible), enabled hidden files. Moved mouse over hidden files: no blinking. Animation over "normal" files still works correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130210/6e4d5705/attachment.htm>