Review Request 108667: Let dolphin look at the firstDayOfWeek as set up in the system's locale settings.

Daniel Kreuter daniel.kreuter85 at googlemail.com
Fri Feb 8 18:40:29 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108667/
-----------------------------------------------------------

(Updated Feb. 8, 2013, 6:40 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Changed the behavior from comparing weeks to comparing distance as suggested by Frank.
Tested it and it works.

When the month of the modified file and today differ, the name of the month + the year will be printed. I removed the logic for Last Week, Two Weeks ago in this case, because it leads more to confusion than that it is useful.


Description
-------

When sorting files by date, dolphin doesn't note the user's system settings. There it's possible to define another first day of week instead of the default (f.e. Sunday instead of Monday).
This patch fixes this issue.


This addresses bug 181337.
    http://bugs.kde.org/show_bug.cgi?id=181337


Diffs (updated)
-----

  dolphin/src/kitemviews/kfileitemmodel.cpp a763b3f 

Diff: http://git.reviewboard.kde.org/r/108667/diff/


Testing
-------

Performed the steps described in comment #3 of the bug report which I won't post here again.


Thanks,

Daniel Kreuter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130208/aa6f01f3/attachment.htm>


More information about the kfm-devel mailing list