Review Request 108693: Places appears twice when unlocking dock widgets.

Thu Feb 7 14:48:20 GMT 2013

> On Feb. 3, 2013, 6:13 p.m., Frank Reininghaus wrote:
> > Thanks, that approach looks better indeed. But now, the panel is called "Bookmarks", and the menu entry still is "Places", right?
> > 
> > I think it might be better to keep the panel name "Places" and just rename the first category inside the panel from "Places" to "Bookmarks". For me, a bookmark sounds like something that the user chose, which is the case only for this first category, and not for the devices that are currently connected. What do you think?
> > 
> > Just for the record, there is also another thing which might be considered problematic then: There is an action "Add to Places" in the context menu, but the panel name 'Places' might not be in the default UI any more. However, I think that we should not rename it to "Add to Bookmarks" because the file dialog still calls the entire thing "Places" and because that might also cause confusion concerning the bookmarks in Konqueror.
> > 
> > Well, resolving this issue in a clean way is a lot more complicated than one might think at first sight (which is probably the reason why nobody tried to work on this before).
> 
> Daniel Kreuter wrote:
>     >Thanks, that approach looks better indeed. But now, the panel is called "Bookmarks", and the menu entry still is "Places", right?
>     
>     Wrong. If the dock widget is now called "Bookmarks", then this name will also appear in the menu entry (as I already mentioned in my last comment).
>     
>     >I think it might be better to keep the panel name "Places" and just rename the first category inside the panel from "Places" to "Bookmarks". For me, a bookmark sounds like something that the user chose, which is the case >only for this first category, and not for the devices that are currently connected. What do you think?
>     
>     Would be possible, but has other changes in common see below.
>     
>     >Just for the record, there is also another thing which might be considered problematic then: There is an action "Add to Places" in the context menu, but the panel name 'Places' might not be in the default UI any more. >However, I think that we should not rename it to "Add to Bookmarks" because the file dialog still calls the entire thing "Places" and because that might also cause confusion concerning the bookmarks in Konqueror.
>     
>     Renaming the category name would implicitly need a rename for the "Add to Places" as well, because this method adds the entry to the places category.
>     Calling the dock widget Bookmarks or Links or whatever wouldn't be so good concerning that the whole file dialog calls the entire thing "Places" as you already pointed out.
>     May it be ok to rename the category to "Links" and change the "Add to Places" to "Add to Links" ? Or maybe "Folders" would be the best for both, because that's what will be added there?
>     
>     
>     >Well, resolving this issue in a clean way is a lot more complicated than one might think at first sight (which is probably the reason why nobody tried to work on this before).
>     
>     I totally agree with you.
> 
> Daniel Kreuter wrote:
>     Ok naming it "Folders" won't be a good idea either, because we already have a DockWidget with that name.
> 
> Emmanuel Pescosta wrote:
>     What if we change the name of the "Places" category from "Places" to "Folders" (makes sense because the items of this category are mainly folders) and drop the other changes? So the "Add to places" menu item also valid after this change.
>     
>     I think this is the easiest solution ;)
> 
> Daniel Kreuter wrote:
>     Hi Emmanuel,
>     
>     the easiest yes, but what about the DockWidget "Folders" which already exists? (Enabled with F7). We would now have 2 items with the same name which could confuse users.

> Wrong. If the dock widget is now called "Bookmarks", then this name will also appear in the menu entry (as I already mentioned in my last comment).

Sorry, you're right of course, I got that wrong.

BTW, my earlier concern that "Add to Places" might be confusing if there is no "Places" at all in the default UI is probably moot. It used to be like that before KDE 4.8, and nobody complained about that.

Hm, I really hate to be the one who is expected to take this kind of decision. Every solution has drawbacks, and I really have no idea what is best. I suppose we have to find a different kind of decision making process for GUI-related changes...

All that I can say is that I don't like the idea of renaming the panel much. The panel has always had the name "Places", and "Places" is all over the place in the code. It feels strange to change that now just because of this issue.

I wonder if simply removing the category name "Places" is really such a bad idea. It would be just like in KDE <= 4.7, only with the difference that the 'Devices' category has a title now (and that there are new categories if Nepomuk is enabled).

- Frank

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108693/#review26588
-----------------------------------------------------------

On Feb. 1, 2013, 5:17 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108693/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 5:17 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> When unlocking the dock widgets, the places text will appear twice.
> I removed all titles of the dock widgets and replaced them with an empty string (removed all for consistency).
> In my opinion, this is the easiest solution I could find so far (I made another proposals on the ML a few hours ago).
> 
> 
> This addresses bug 301405.
>     http://bugs.kde.org/show_bug.cgi?id=301405
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 8ed31de 
> 
> Diff: http://git.reviewboard.kde.org/r/108693/diff/
> 
> 
> Testing
> -------
> 
> Open dolphin and unlock each dock (places, folders, information and terminal). There should only be the two buttons in the title bar, but no title, Drag & Drop should work just like before.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130207/29d28b0f/attachment.htm>