Review Request 108667: Let dolphin look at the firstDayOfWeek as set up in the system's locale settings.

[Daniel Kreuter]

> On Feb. 3, 2013, 6:03 p.m., Frank Reininghaus wrote:
> > Thanks for the new patch! Looks indeed better now. I've added some comments below, mostly coding-style related.
> > 
> > Have you already tested the code for different 'modified week days'? It looks like it might go wrong if the weekStartDay is Monday and a file has been modified, e.g., on a Monday 10 days ago. But I might be wrong, I haven't actually tested it yet.

>Have you already tested the code for different 'modified week days'? It looks like it might go wrong if the weekStartDay is Monday and a file has been modified, e.g., on a Monday 10 days ago. But I might be wrong, I >haven't actually tested it yet.
Good point, and it seems that there is a little problem here. I have atm firstDayOfWeek = 7 (Sunday), recreated my files with the script and Last Monday (date 28-01-2013) has the title Monday instead of Two weeks ago.
I will have a look at why he is doing that.
The other issues below are already fixed and will be available in the next patch (after I finished debugging the issue above)


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108667/#review26587
-----------------------------------------------------------


On Feb. 1, 2013, 5:03 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108667/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 5:03 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> When sorting files by date, dolphin doesn't note the user's system settings. There it's possible to define another first day of week instead of the default (f.e. Sunday instead of Monday).
> This patch fixes this issue.
> 
> 
> This addresses bug 181337.
>     http://bugs.kde.org/show_bug.cgi?id=181337
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 1062aa5 
> 
> Diff: http://git.reviewboard.kde.org/r/108667/diff/
> 
> 
> Testing
> -------
> 
> Performed the steps described in comment #3 of the bug report which I won't post here again.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130204/23b46d54/attachment.htm>