Review Request 108693: Places appears twice when unlocking dock widgets.

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108693/#review26533
-----------------------------------------------------------


Looks good. :) Thanks!

- Emmanuel Pescosta


On Feb. 1, 2013, 5:17 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108693/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 5:17 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> When unlocking the dock widgets, the places text will appear twice.
> I removed all titles of the dock widgets and replaced them with an empty string (removed all for consistency).
> In my opinion, this is the easiest solution I could find so far (I made another proposals on the ML a few hours ago).
> 
> 
> This addresses bug 301405.
>     http://bugs.kde.org/show_bug.cgi?id=301405
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 8ed31de 
> 
> Diff: http://git.reviewboard.kde.org/r/108693/diff/
> 
> 
> Testing
> -------
> 
> Open dolphin and unlock each dock (places, folders, information and terminal). There should only be the two buttons in the title bar, but no title, Drag & Drop should work just like before.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130202/3c5e59b9/attachment.htm>