Review Request 108693: Places appears twice when unlocking dock widgets.

[Frank Reininghaus]

> On Jan. 31, 2013, 9:54 p.m., Kai Uwe Broulik wrote:
> > I think this is not a good idea.
> > Better would be to hide the "Places" category title if the panels are unlocked
> 
> Emmanuel Pescosta wrote:
>     > I removed all titles of the dock widgets and replaced them with an empty string (removed all for consistency).
>     I think there will be a empty panels menu or not? - Only a checkbox for every panel is not so good ;)
>     
>     > Better would be to hide the "Places" category title if the panels are unlocked
>     Hiding the category title is also a bad solution (at least in my opinion), because the UI will look a little bit inconsistent.
>     
>     I think that renaming the current "Places" panel to something else (e.g. Links, Bookmarks,  ...) would be the best/easiest solution. (Also suggested by Luigi Toscano on KFM-Devel)
>
> 
> Daniel Kreuter wrote:
>     I will check the panel if the titles are related or if they don't depend on each other.
>     
>     Hiding the category name is not a good idea because the formatting and position of the title and category name are different.
>     
>     Renaming would be possible since we have also other elements like devicrs in that dock.

Thanks Daniel for the patch! I agree that the duplication of the word "Places" can be irritating, and it's good to see that you're working on fixing this. Like the others, I'm a bit sceptical if removing all panel names is the best way to do it. I think that the menu would not be harmed by this, but having consistent panel names and menu entries is a good thing IMHO.

Maybe we could rename the "Places" category inside the panel to "Bookmarks" or something like that?

(Just for the record: the recommended, i.e., most efficient, way to create an empty QString is QString().)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108693/#review26474
-----------------------------------------------------------


On Jan. 31, 2013, 8:55 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108693/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 8:55 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> When unlocking the dock widgets, the places text will appear twice.
> I removed all titles of the dock widgets and replaced them with an empty string (removed all for consistency).
> In my opinion, this is the easiest solution I could find so far (I made another proposals on the ML a few hours ago).
> 
> 
> This addresses bug 301405.
>     http://bugs.kde.org/show_bug.cgi?id=301405
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 8ed31de 
> 
> Diff: http://git.reviewboard.kde.org/r/108693/diff/
> 
> 
> Testing
> -------
> 
> Open dolphin and unlock each dock (places, folders, information and terminal). There should only be the two buttons in the title bar, but no title, Drag & Drop should work just like before.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130201/7a427f10/attachment.htm>