Review Request 113168: Filter expanded folders

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113168/
-----------------------------------------------------------

(Updated Dec. 22, 2013, 5:09 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

The current filtering implementation doesn't filter out expanded directories, also
when there are no sub-items anymore and they don't match with the filter string.

With this patch the filtering is done right ;)

For example (folders a, a/b and a/b/c):
Expand a and b

a-|
  |-b-|
      |-c

Set the filter string to "b". 

  * Current implementation

a-|
  |-b-|
      |-c

  * Patched version:

a-|
  |-b


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.h d005705 
  dolphin/src/kitemviews/kfileitemmodel.cpp ea7ac2f 
  dolphin/src/tests/kfileitemmodeltest.cpp 62ff4fa 

Diff: https://git.reviewboard.kde.org/r/113168/diff/


Testing
-------

Works fine for me.

Old unit tests don't pass.
New unit tests pass.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131222/2dbdf668/attachment.htm>