Review Request 114560: Disable the "Create Folder..." action (triggered by F10) in read-only directories

[Frank Reininghaus]

> On Dec. 21, 2013, 12:13 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/views/dolphinviewactionhandler.h, line 259
> > <https://git.reviewboard.kde.org/r/114560/diff/1/?file=226659#file226659line259>
> >
> >     Why not using the action collection?

You're right - using the action collection to retrieve is action is easier. Thanks for the hint!


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114560/#review45986
-----------------------------------------------------------


On Dec. 20, 2013, 7:28 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114560/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 7:28 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 294054
>     http://bugs.kde.org/show_bug.cgi?id=294054
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Pressing F10 in a read-only directory and then clicking "OK" in the "Create new folder" dialog will trigger an error message because it is not possible to create a new folder.
> 
> To fix this, one can keep a pointer to the action in DolphinViewActionHandler, connect that class to the view's writeStateChanged(bool) signal, and update the action when this signal is received.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinviewactionhandler.h edbe41b 
>   dolphin/src/views/dolphinviewactionhandler.cpp 9a9718c 
> 
> Diff: https://git.reviewboard.kde.org/r/114560/diff/
> 
> 
> Testing
> -------
> 
> Fixes the problem for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131222/ad6d7ba2/attachment.htm>