Review Request 113957: Rename of "Recently Accessed" to "Recently Saved"

Frank Reininghaus frank78ac at googlemail.com
Sat Dec 14 10:44:23 GMT 2013


Hi,

it's actually preferred to add additional comments to the review
request directly. Splitting the conversation between the review
request and regular mails makes the conversation hard to follow for
anyone who might try to find out something about it in the future.

2013/12/11 Richard llom:
> Frank Reininghaus wrote:
>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/113957/#review45525
>> -----------------------------------------------------------
>>
>> Ship it!
>>
>>
>> Looks good, thanks! Do you have a git account?
>>
> I don't know, so far I accomplished everything with the identity.kde.org
> account. Does this include a git account?

No. We can push the patch for you then.

>> If yes, feel free to push to master once you have tested that it still
>> works as expected, i.e., that the change does not cause unexpected
>> breakage at run time.
>>
> Does this mean I have to compile things? Actually I don't know how to do
> this.

Does that mean that you did not even check if the patched code still
builds? I'm a bit surprised now - actually, I think that everyone
assumes implicitly that at least this has been verified for *every*
patch uploaded to ReviewBoard, unless explicitly stated otherwise.

Actually, I think that I clearly stated in

https://bugs.kde.org/show_bug.cgi?id=304854#c7

that the reason why I would appreciate help with this change is that
careful testing of the change is IMHO needed (it might seem unlikely
that it breaks at runtime, but one should definitely test it in order
not to cause unexptected trouble).

But I hope that I misunderstood you ;-)

Cheers,
Frank




More information about the kfm-devel mailing list