Review Request 112312: Make thumbnail generation more responsive to scrolling/paging

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112312/#review38747
-----------------------------------------------------------



dolphin/src/kitemviews/kfileitemlistview.cpp
<http://git.reviewboard.kde.org/r/112312/#comment28607>

    This comment should be moved to the place where those constants are declared.


- Christoph Feck


On Aug. 27, 2013, 3:03 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112312/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 3:03 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The thumbnail generation is delayed by several timers to make the user interface more responsive. During scrolling, however, it delayed the generation by 300 ms, which I felt to long.
> 
> Looking at the code, this long interval is supposed to be used for zooming, where previously generated thumbnails are recreated at a new size, and moving the zoom slider would otherwise recreated them too often.
> 
> But the long interval is also used for scrolling, because the thumbnail generation is broken up into multiple chunks, and only the first chunk used the short interval. If you scroll down to the place where no thumbnails have been generated yet, it waits for a long time before resuming.
> 
> Suggested patch fixes this.
> 
> 
> This addresses bug 322093.
>     http://bugs.kde.org/show_bug.cgi?id=322093
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemlistview.h 49ff773 
>   dolphin/src/kitemviews/kfileitemlistview.cpp 1f0fcbd 
> 
> Diff: http://git.reviewboard.kde.org/r/112312/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130827/11ce55cd/attachment.htm>