Review Request 112178: Make use of the already existing DolphinNewFileMenuObserver singleton class to achieve a better error handling (DolphinNewFileMenu)

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112178/
-----------------------------------------------------------

(Updated Aug. 25, 2013, 10:13 a.m.)


Review request for Dolphin and David Faure.


Changes
-------

Replaced the action name "create_new" of DolphinNewFileMenu with "new_menu", so that nothing breaks in DolphinPart.

Added David Faure as reviewer, because of the DolphinPart changes.


Description
-------

Replaced all KNewFileMenu usages in DolphinPart by DolphinNewFileMenu.

Removed all signal-slot-connections related to DolphinNewFileMenu->errorMessage(QString)
in DolphinMainWindow and DolphinContextMenu and replaced it by a better solution.

Now we make use of the already existing DolphinNewFileMenuObserver singleton class to achieve a better
error handling, because every newly created DolphinContextMenu instance registers himself by DolphinNewFileMenuObserver
and we use this to connect the errorMessage(QString) signal of every DolphinContextMenu instance to the errorMessage(QString)
signal of the DolphinNewFileMenuObserver singleton class.

So we need only one connection from DolphinNewFileMenuObserver to DolphinMainWindow (or to DolphinPart) to
collect all error messages thrown by every DolphinNewFileMenu instance.


Diffs (updated)
-----

  dolphin/src/CMakeLists.txt 6856991 
  dolphin/src/dolphincontextmenu.h c9840ea 
  dolphin/src/dolphincontextmenu.cpp 3deeb38 
  dolphin/src/dolphinmainwindow.cpp 5cc608f 
  dolphin/src/dolphinnewfilemenu.h ae58813 
  dolphin/src/dolphinnewfilemenu.cpp 480889f 
  dolphin/src/dolphinpart.h 172bfaf 
  dolphin/src/dolphinpart.cpp de4c607 
  dolphin/src/views/dolphinnewfilemenuobserver.h 726122c 
  dolphin/src/views/dolphinnewfilemenuobserver.cpp 1cb5739 

Diff: http://git.reviewboard.kde.org/r/112178/diff/


Testing
-------

All error messages are shown properly.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130825/b966f073/attachment.htm>