Review Request 112256: Move cursor to begin/end of selection before canceling it

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112256/#review38523
-----------------------------------------------------------

Ship it!


Thanks, looks good and works :-)

- Frank Reininghaus


On Aug. 25, 2013, 9:32 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112256/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 9:32 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Dolphin uses QTextEdit for inline renaming, which does not move the cursor to begin/end of selection, probably because for large texts, this can cause unexpected loss of focus.
> 
> Dolphin does not use large texts, but usually only a few lines.
> 
> 
> This addresses bug 323946.
>     http://bugs.kde.org/show_bug.cgi?id=323946
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 9f20afe 
> 
> Diff: http://git.reviewboard.kde.org/r/112256/diff/
> 
> 
> Testing
> -------
> 
> Pressing Left/Right with a selection now works the same as in QLineEdit.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130825/6a6a6dd5/attachment.htm>