Review Request 111988: Try to make sure that renaming inline does not cause crashes

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111988/#review37965
-----------------------------------------------------------

Ship it!


Ship It!

- Emmanuel Pescosta


On Aug. 10, 2013, 9:20 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111988/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2013, 9:20 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> We had some trouble with inline renaming some time ago, which is mostly resolved now. However, there recently was a crash report which looks related to inline renaming.
> 
> Like in some of the earlier crashes, it seems that the editor is deleted during a nested event loop that is run inside its mouseMoveEvent method. I could imagine that this can happen if, for example, the edited file is deleted (or removed from the view in some other way) in this event loop (there might be possibilities). In that case, the destructor of the widget will delete the editor.
> 
> I think we should delete the editor in this destructor with deleteLater(). My patch always defers the deletion of the editor until the latest possible moment (at least the lastest possible moment which is accessible from KStandardItemListWidget). I hope that this resolves the problem.
> 
> 
> This addresses bug 322969.
>     http://bugs.kde.org/show_bug.cgi?id=322969
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp b429211 
> 
> Diff: http://git.reviewboard.kde.org/r/111988/diff/
> 
> 
> Testing
> -------
> 
> Renaming still works OK. Tried some of the things that caused trouble in the past (dragging text to the Places Panel, clicking "Speak Text" in the context menu, keyboard focus handling). Everything seems to work fine.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130816/3543a161/attachment.htm>