Review Request 111934: dolphin: Show full file info when only one file is selected

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111934/#review37928
-----------------------------------------------------------

Ship it!


Oops, I see that forgot to say in my last comment that you can just go ahead and push both commits to master. Sorry about that!

Thanks for your work - I agree that it feels much better when this change is applied :-)

- Frank Reininghaus


On Aug. 15, 2013, 6:15 p.m., Fabio D'Urso wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111934/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 6:15 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The purpose of this change is to give the user a chance to see file information if it doesn't fit in the status bar (see bug 260717), by allowing to click on the file and hover on the status bar.
> 
> As it's now possible to have status bar texts starting with "<qt>", DolphinPart::updateStatusBar() must escape strings. Otherwise, filenames such as "<qt>Tes<font color=red>t" would be rendered as HTML data in konqueror's status bar when selected.
> 
> <MOVED-TO-REVIEW-REQUEST-112106>
> This patch also changes the status bar text dolphin shows when a folder is hovered. It now shows full folder info, eg:
>   "mydir (folder, symlink to /opt/mydir")
> instead of:
>   "mydir"
> This is consistent with dolphin's behavior on regular files, and DolphinPart already does that (DolphinPart::slotRequestItemInfo has no special cases for folders).
> </MOVED-TO-REVIEW-REQUEST-112106>
> 
> 
> This addresses bug 260717.
>     http://bugs.kde.org/show_bug.cgi?id=260717
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinpart.cpp 81fbacb 
>   dolphin/src/views/dolphinview.cpp 375bd3e 
> 
> Diff: http://git.reviewboard.kde.org/r/111934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130816/6ddfc724/attachment.htm>