Review Request 111989: Cut the ropes between DolphinMainWindow and DolphinNewFileMenu

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111989/#review37590
-----------------------------------------------------------

Ship it!


Looks good, thanks!

- Frank Reininghaus


On Aug. 10, 2013, 11:01 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111989/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2013, 11:01 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Cut the ropes between DolphinMainWindow and DolphinNewFileMenu. 
> Error handling is now done via signals.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.h 180f917 
>   dolphin/src/dolphincontextmenu.cpp f4b4698 
>   dolphin/src/dolphinmainwindow.cpp 73001bf 
>   dolphin/src/dolphinnewfilemenu.h 0d33608 
>   dolphin/src/dolphinnewfilemenu.cpp 9d9baab 
> 
> Diff: http://git.reviewboard.kde.org/r/111989/diff/
> 
> 
> Testing
> -------
> 
> Error handling works.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130812/6d88f484/attachment.htm>