Review Request 111968: Make newly opened search tabs close- and editable

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111968/
-----------------------------------------------------------

(Updated Aug. 9, 2013, 5:48 p.m.)


Review request for Dolphin.


Changes
-------

Sorry, wrong group.


Description
-------

When you open a new tab while the search mode is enabled, the newly opened 
tab also starts the same search (Because new tab is opened with the current 
view url), but the search box is in read-only mode. 
So you cannot close the search bar nor edit the search text.

This patch fixes this by parsing the search url. The value of the "search"
parameter is used as search text and the value of the "url" parameter is used 
for the search path ("root" folder for the search when "Search from here" mode 
is enabled).


This addresses bug 311950.
    http://bugs.kde.org/show_bug.cgi?id=311950


Diffs
-----

  dolphin/src/dolphinviewcontainer.cpp 1e9e79a 

Diff: http://git.reviewboard.kde.org/r/111968/diff/


Testing
-------

1. Start a search (e.g. "kde") in folder $HOME/Downloads
2. Open a new tab
3. Edit the search mode should work
4. Close the search
5. The view from the newly opened tab should open $HOME/Downloads

All five points works for me.

Btw:
Please test it with nepomuk searches, because nepomuk doesn't work for me (Don't know why?! - Maybe smth. is wrong in the arch/kde-unstable repo)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130809/33fa06c5/attachment.htm>