Review Request 111934: dolphin: Show full file info when only one file or folder is selected

[Emmanuel Pescosta]

> On Aug. 8, 2013, 9:03 p.m., Frank Reininghaus wrote:
> > Thanks for the patch.
> > 
> > About the DolphinViewContainer change: I thought that it might be worth investigating why folders are treated separately at all. I found out with quickgit.kde.org and repeatedly swithching between "history" and "blame" that it's done since this commit:
> > 
> > http://quickgit.kde.org/?p=kde-baseapps.git&a=commitdiff&h=39992aad7096d5caa6b9b6cb1e28f6ea2ef234ca
> > 
> > The commit message doesn't really tell much about this part of the change though, and it does not seem to be related to the bug it mentions either.
> > 
> > I could imagine that the reason was that the "(folder)" thing looks a bit superfluous when the icon already tells that it's a folder, but if that was considered bad, then changing that in KFileItem::getStatusBarInfo() might be better... Therefore, I'd say that the DolphinViewContainer thing is fine for master.
> > 
> > 
> > About the change in DolphinView: I somehow like it that "selected" is being shown at the moment. But I also see that you are trying to improve the "cannot see the link destination" issue. I really don't know what's best - other opinions would be appreciated.
> > 
> > BTW, I think it would have been better to make two commits out of this and merge the DolphinView one with https://git.reviewboard.kde.org/r/111935/. Why not treat one change in DolphinView and another one in DolphinPart that is needed because of that together? Makes much more sense than mixing the two issues in DolphinView and DolphinViewContainer here - if different changes are made in one commit, this can make the history very hard to understand, see the commit I linked to above ;-)

> other opinions would be appreciated.
+1 from my side for this patch, because it's great to see the link destination on hovering.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111934/#review37384
-----------------------------------------------------------


On Aug. 7, 2013, 1:12 p.m., Fabio D'Urso wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111934/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 1:12 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The purpose of this change is to give the user a chance to see file information if it doesn't fit in the status bar (see bug 260717), by allowing to click on the file and hover on the status bar.
>     
> This patch also changes the status bar text dolphin shows when a folder is hovered. It now shows full folder info, eg:
>   "mydir (folder, symlink to /opt/mydir")
> instead of:
>   "mydir"
> This is consistent with dolphin's behavior on regular files, and DolphinPart already does that (DolphinPart::slotRequestItemInfo has no special cases for folders).
> 
> 
> This addresses bug 260717.
>     http://bugs.kde.org/show_bug.cgi?id=260717
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp 1e9e79a 
>   dolphin/src/views/dolphinview.cpp 20bc9f5 
> 
> Diff: http://git.reviewboard.kde.org/r/111934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130809/d773f32e/attachment.htm>