Review Request 111807: Add some unit test for groups in KFileItemModel
Commit Hook
null at kde.org
Sun Aug 4 20:09:53 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111807/
-----------------------------------------------------------
(Updated Aug. 4, 2013, 7:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin.
Description
-------
This new unit test tests grouping in KFileItemModel, in particular the aspects that I would have broken with https://git.reviewboard.kde.org/r/111721/, as Emmanuel found out fortunately :-)
Moreover, the commit reduces the timeout for the "resort all items" timer. This greatly speeds up the unit tests.
Diffs
-----
dolphin/src/tests/kfileitemmodeltest.cpp 0ad7a37
Diff: http://git.reviewboard.kde.org/r/111807/diff/
Testing
-------
New unit test passes, and breaks when I apply the current version of https://git.reviewboard.kde.org/r/111721/
Thanks,
Frank Reininghaus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130804/263b16d2/attachment.htm>
More information about the kfm-devel
mailing list