Review Request 111836: dolphin: Escape text in statusbar tooltip

[Frank Reininghaus]

> On Aug. 1, 2013, 2:42 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! Could you describe how the problem can be reproduced? When I move the mouse cursor to the status bar, the file name disappears from the status bar, so I don't get the tool tip at all.
> 
> Fabio D'Urso wrote:
>     Yes, sorry: create a file named "Tes<font color=red>t test test test test test", select it and hover on the status bar.

Thanks. The problem was that I created not a file, but a folder with such a name, and the name of a selected folder is not shown in the status bar. Not sure why it is that way, but it's unrelated to the bug you've found anyway.

The patch looks good to me, feel free to commit. Bonus points if you create a bug report and close it with the commit :-)

Thanks for your work!


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111836/#review36918
-----------------------------------------------------------


On Aug. 1, 2013, 1:58 p.m., Fabio D'Urso wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111836/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 1:58 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> I've found that the statusbar's tooltip renders HTML-looking filenames as HTML too. This patch escapes the tooltip text.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 1489191 
> 
> Diff: http://git.reviewboard.kde.org/r/111836/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130803/ef2f8463/attachment.htm>