Review Request 111807: Add some unit test for groups in KFileItemModel

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111807/#review36991
-----------------------------------------------------------

Ship it!


Ship It!

- Emmanuel Pescosta


On July 30, 2013, 10:01 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111807/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 10:01 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> This new unit test tests grouping in KFileItemModel, in particular the aspects that I would have broken with https://git.reviewboard.kde.org/r/111721/, as Emmanuel found out fortunately :-)
> 
> Moreover, the commit reduces the timeout for the "resort all items" timer. This greatly speeds up the unit tests.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/tests/kfileitemmodeltest.cpp 0ad7a37 
> 
> Diff: http://git.reviewboard.kde.org/r/111807/diff/
> 
> 
> Testing
> -------
> 
> New unit test passes, and breaks when I apply the current version of https://git.reviewboard.kde.org/r/111721/
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130802/481e58cf/attachment.htm>