Review Request 109966: Don't try to change the icon of the "sort" action menu

[Daniel Faust]

> On April 11, 2013, 4:32 p.m., Frank Reininghaus wrote:
> > Thanks for the patch!
> > 
> > I see that the code in question has been added in http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=76258ddc9c3cb037b70ea2a060608ae4e397ae88 which originates in a review request by Todd: https://svn.reviewboard.kde.org/r/3862/
> > 
> > @Todd: can you comment on this?

Any news? KDE 4.10.3 will be tagged soon.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109966/#review30927
-----------------------------------------------------------


On April 11, 2013, 3:40 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109966/
> -----------------------------------------------------------
> 
> (Updated April 11, 2013, 3:40 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> When changing the sorting through the "sort" action menu, dolphin will try to change the icon.
> However this change fails and just removes the icon.
> 
> In my opinion there is no need at all to change the icon, it should always stay the same (it can be changed by the user with the kde tool bar editor btw.).
> 
> 
> This addresses bug 255819.
>     http://bugs.kde.org/show_bug.cgi?id=255819
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinviewactionhandler.cpp c7832d7 
> 
> Diff: http://git.reviewboard.kde.org/r/109966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130428/cce308d9/attachment.htm>