Review Request 110133: Add "Open Path" context menu action

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110133/#review31521
-----------------------------------------------------------


Thanks for the patch. I've never had much to do with the search stuff, so I don't really feel qualified to say if this is needed or not. But I guess it won't hurt much. First I was confused about the use of "Path", rather than "Parent Folder", but it seems that this has been changed intentionally some time ago.

Two questions:

1. Is there a reason for the separator between the new action and the other "Open Path" ones? I'm not saying that it's wrong, I'm just curious if there is some sort of general guideline that you are following here.

2. Could you please follow the coding style and not make whitespace changes in source lines that you don't actually change?

- Frank Reininghaus


On April 23, 2013, 8:19 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110133/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 8:19 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> As I'm not a particular fan of tabbed browsing (at least not in a file manager), I need a "Open Path" action that does neither open a new tab nor a new window. This patch adds this option.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.h 3d0005d 
>   dolphin/src/dolphincontextmenu.cpp bb26c7a 
>   dolphin/src/dolphinmainwindow.cpp 8ed31de 
> 
> Diff: http://git.reviewboard.kde.org/r/110133/diff/
> 
> 
> Testing
> -------
> 
> Tested with normal and split view. Works :-)
> 
> 
> File Attachments
> ----------------
> 
> Context menu entry
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/23/openpath.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130424/e3354db7/attachment.htm>