Review Request 109950: Scroll to newly pasted/dropped files.

[Emmanuel Pescosta]

> On April 19, 2013, 3:32 p.m., Frank Reininghaus wrote:
> > Thanks for the new patch and sorry for the late response - I was pretty busy with non-KDE things this week.
> > 
> > The new approach looks good to me :-) There's just one thing that might need further thought - what happens if many large files are pasted, such that they are not all created together, but rather in multiple batches? They are all selected now thanks to your recent efforts in this area, which are much appreciated. But with this patch, the current item (and possibly the scroll offset of the view) would change every time a new item appears, right?
> > 
> > I don't see a good solution to this issue. Maybe we do need a new bool member (like you suggested in version 1) after all which is set to true when pasting and set to false after the markUrlAsCurrent() call has been made for the first pasted item in slotAboutToCreate().

> sorry for the late response
Hello Frank - No problem ;)

> what happens if many large files are pasted, such that they are not all created together
I will fix that problem asap.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109950/#review31296
-----------------------------------------------------------


On April 15, 2013, 7:33 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109950/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 7:33 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Scroll to newly pasted/dropped files.
> 
> If multiple files are pasted/dropped, then it scrolls
> to the first pasted/dropped file.
> 
> 
> This addresses bug 315722.
>     http://bugs.kde.org/show_bug.cgi?id=315722
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp d1e154f 
> 
> Diff: http://git.reviewboard.kde.org/r/109950/diff/
> 
> 
> Testing
> -------
> 
> Works. All test passed.
> 
> Paste one file -> Scrolls to this file
> Drop one file -> Scrolls to this file
> Paste multiple files -> Scrolls to the first inserted file
> Drop multiple files -> Scrolls to the first inserted file
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130419/7e80da00/attachment.htm>