Review Request 109893: Fixed a Dolphin 2.x Regression: no option to select whole group in grouped view

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109893/
-----------------------------------------------------------

(Updated April 15, 2013, 7:05 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin and Frank Reininghaus.


Description
-------

Fixed a Dolphin 2.x Regression: no option to select whole group in grouped view

Added the (de-)selector widget to the item list group-header, to (de-)select all items in the group.

This feature got lost in Dolphin 2.0


This addresses bug 292508.
    http://bugs.kde.org/show_bug.cgi?id=292508


Diffs
-----

  dolphin/src/kitemviews/private/dolphingraphicswidget.cpp PRE-CREATION 
  dolphin/src/kitemviews/private/dolphingraphicswidget.h PRE-CREATION 
  dolphin/src/kitemviews/kstandarditemlistwidget.cpp 6adb546 
  dolphin/src/kitemviews/kstandarditemlistgroupheader.cpp 1e23c0a 
  dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a 
  dolphin/src/kitemviews/kitemlistwidget.h 55181fa 
  dolphin/src/kitemviews/kitemlistview.cpp 9ebad7f 
  dolphin/src/kitemviews/kitemlistview.h cd59ddc 
  dolphin/src/kitemviews/kitemlistgroupheader.cpp 17c95a9 
  dolphin/src/kitemviews/kitemlistgroupheader.h 1e8ed2c 
  dolphin/src/kitemviews/kitemlistcontroller.cpp c6239df 
  dolphin/src/CMakeLists.txt ffb232c 
  dolphin/src/kitemviews/kitemlistcontroller.h 4d5fee3 

Diff: http://git.reviewboard.kde.org/r/109893/diff/


Testing
-------

Works fine. All tests passed.

* Enable grouping
* Hover the group header
* Click on the selector -> All items in this group are selected
* Click on the selector again -> No item in this group is selected


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130415/c6669af1/attachment.htm>