Review Request 109960: Fix moving image while transitioning to hover pixmap

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109960/
-----------------------------------------------------------

(Updated April 12, 2013, 2:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

Just when I think I am done with Dolphin mouse hover animation, someone points me to a regression: http://agateau.com/2013/03/27/fixing-a-subtle-animation-bug-in-dolphin/#comment-854141951

Previous code used KStandardItemListWidget::drawPixmap() on pixmap1 and pixmap2 and QPainter::drawPixmap() to draw the on the widget. This caused the movement demonstrated in the linked video when m_pixmapPos.x() was not a round value.


Diffs
-----

  dolphin/src/kitemviews/kstandarditemlistwidget.cpp 6adb546332e234c77bcdb68313b2b87860859262 

Diff: http://git.reviewboard.kde.org/r/109960/diff/


Testing
-------


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130412/90e2c573/attachment.htm>