Review Request 109900: Show the number of items of every group in the group headers

[Frank Reininghaus]

> On April 9, 2013, 6:36 a.m., Frank Reininghaus wrote:
> > Thanks for the patch, but as I said earlier: large changes should really be discussed in advance or at least be explained properly. It's not clear at all to me why a new class is needed for this.
> 
> Emmanuel Pescosta wrote:
>     This feature can also be implemented in KStandardItemListGroupHeader directly (I did it for testing - only a few lines are needed), but I think this is the wrong place for that, because the KStandardItemListGroupHeader is not only used in the view-widget, but also in the places-panel.
>     
>     To make the code easier to maintain and to understand, I removed all the unneeded stuff (Pixmap handling + Item count stuff) from KStandardItemListGroupHeader and created KFileItemListGroupHeader to implement it there. 
>     
>     So we have only things in the KStandardItemListGroupHeader base class, which are really needed there. Everything else (Pixmap + Item count stuff in this patch) is implemented in the specialized group-header class. (Same as KStandardItemListWidget and KFileItemListWidget).
>     
>     > It's not clear at all to me why a new class is needed for this.
>     I hope that these changes are understandable ;)
>     
>     What do you think about the feature? Is it okay for Dolphin?
>

Thanks for your explanations! I thought about this for some time. I'm sorry, but I came to the conclusion that we should better not add this feature. While showing the number of items may be useful in some rare situations, I believe that it is probably usually not extremely useful for most users. Some might even perceive this (in most cases superfluous) information as something that clutters the view unnecessarily.

And if we did add that feature nonetheless, I can already see new requests coming like "Make it consistent with the status bar and count files and folders separately (at least if not sorting by type and "sort folders first" is disabled), also show the total size of the files in one group, etc.

Sorry about that, I see that you put quite some time into this.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109900/#review30739
-----------------------------------------------------------


On April 7, 2013, 9:21 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109900/
> -----------------------------------------------------------
> 
> (Updated April 7, 2013, 9:21 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Show the number of items of every group in the group headers
> 
> See attached screenshot
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt ffb232c 
>   dolphin/src/kitemviews/kfileitemlistgroupheader.h PRE-CREATION 
>   dolphin/src/kitemviews/kfileitemlistgroupheader.cpp PRE-CREATION 
>   dolphin/src/kitemviews/kfileitemlistview.h d795c96 
>   dolphin/src/kitemviews/kfileitemlistview.cpp b7f7455 
>   dolphin/src/kitemviews/kstandarditemlistgroupheader.h 26158d6 
>   dolphin/src/kitemviews/kstandarditemlistgroupheader.cpp 1e23c0a 
> 
> Diff: http://git.reviewboard.kde.org/r/109900/diff/
> 
> 
> Testing
> -------
> 
> Works. All tests passed.
> 
> Also correct item count after creating/deleting items.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/snapshot1.png
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130411/331fe0bc/attachment.htm>