Review Request 109843: Make sure that icons are determined for the visible items first

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109843/#review30868
-----------------------------------------------------------

Ship it!


No regression found. :)
So ship it!

- Emmanuel Pescosta


On April 3, 2013, 4:09 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109843/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 4:09 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> When entering a large folder, it can happen that KFileItemModelRolesUpdater starts its synchronous determination of icon names before the view has informed it about the visible index range. This causes the problem that some visible icons might still be unkown after 200 ms, and that "unknown" icons are then replaced by the right ones asynchronously.
> 
> I propose to fix this by assuming that the first items are visible if we don't have a valid index range yet. The max. number of visible items is determined by the view, and a default value of 100 is used.
> 
> 
> This addresses bug 316129.
>     http://bugs.kde.org/show_bug.cgi?id=316129
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemlistview.cpp b7f7455 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h 68559d8 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 9fca8a1 
>   dolphin/src/kitemviews/kitemlistview.h cd59ddc 
>   dolphin/src/kitemviews/kitemlistview.cpp 9ebad7f 
> 
> Diff: http://git.reviewboard.kde.org/r/109843/diff/
> 
> 
> Testing
> -------
> 
> Works for me (tested by artificially making the resolving of the roles for an item slower).
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130410/330b76f4/attachment.htm>