Review Request 106555: Improving the Accessibility Interface for Dolphin

[Albert Astals Cid]

> On Feb. 6, 2013, 11:15 p.m., Albert Astals Cid wrote:
> > Has this been committed? It has Ship It! but still shows open in reviewboard.
> 
> Emmanuel Pescosta wrote:
>     Nope. 
>     Latest commit in this section was d06163ed9a2aceaa6d6198a57a366e2dd287c4cb added by Amandeep Singh 4 months ago (see https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/master/changes/dolphin/src/kitemviews/kitemlistviewaccessible.h)
> 
> Albert Astals Cid wrote:
>     So should it be commited or there are still things that need to be fixed?
>     Frank? Amandeep?
>
> 
> Frank Reininghaus wrote:
>     This has been committed half a year ago, don't know why closing the review request failed.
>     
>     http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=e3ee2443f5c0f731fa7b4c3f396454f91cb820bc

I'd say because you wrote "REVIEW :" instead of "REVIEW:", closing manually


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106555/#review26804
-----------------------------------------------------------


On Sept. 24, 2012, 10:23 p.m., Amandeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106555/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 10:23 p.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Hi Frank. Sorry for unintended damage. I have removed the layouter function from public in this diff. Also had to make other changes to make the AccessibleInterface work with Orca as well.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp 580cf5b 
>   dolphin/src/kitemviews/kitemlistviewaccessible.cpp 6ca9cc8 
>   dolphin/src/kitemviews/kitemlistview.h 2c30c6f 
> 
> Diff: http://git.reviewboard.kde.org/r/106555/diff/
> 
> 
> Testing
> -------
> 
> Tried it with Orca and KMag
> 
> 
> Thanks,
> 
> Amandeep Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130409/2a31cfcb/attachment.htm>