Review Request 109622: Move "Bluetooth" entry from Places to Devices category

[Frank Reininghaus]

> On March 21, 2013, 11:56 a.m., Frank Reininghaus wrote:
> > Thanks for the patch, looks reasonable!
> > 
> > Even though the places view in kdelibs does not support categories, maybe the "device/non-device" status could affect the default sorting of the places? Speaking of sorting: could you check before pushing if it still works OK in the file dialog's places view after the sorting of the devices is changed in Dolphin and vice versa? Can't test it myself due to lack of suitable hardware.
> > 
> >
> 
> Kai Uwe Broulik wrote:
>     Only issue I could find is that when you move it up in the the Open file dialog (ie. below Home or Trash), it will stay there for those dialogs but still be in the Devices section of Dolphin, ie. down below. Not sure if giving it a device state in kdelibs solves that, though. In kdelibs it's more complicated to tell it it's a device. In Dolphin I just needed the three lines here, but in kdelibs when it is a device, it is referenced by UID which a non-device doesn't have.
> 
> Àlex Fiestas wrote:
>     Imho you should ship it

Yes, I agree, sorry if that wasn't clear from my earlier message. Thanks for your work!


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109622/#review29624
-----------------------------------------------------------


On March 20, 2013, 10:11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109622/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 10:11 p.m.)
> 
> 
> Review request for Dolphin, Àlex Fiestas and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This patch moves the "Bluetooth" entry from Places to Devices category.
> Made sense to me that Bluetooth stuff is also under devices. Also makes Bluetooth devices (ie. you add your smartphone to the places list) appear there.
> 
> 
> This addresses bug 301276.
>     http://bugs.kde.org/show_bug.cgi?id=301276
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitem.cpp 75e14d0 
> 
> Diff: http://git.reviewboard.kde.org/r/109622/diff/
> 
> 
> Testing
> -------
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130402/3363a69d/attachment.htm>