Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106569/#review19457
-----------------------------------------------------------

Ship it!


Thanks Dawit for the explanation! I had a quick look at the Konqueror sources last night, but apparently I was too tired to find the right place in KonqView. I only saw that KonqMainWindow installs an event filter for the KonqCombo, but that is of course irrelevant to the bug that we see here (somehow my tired brain confused KonqCombo with Konqueror's tab class and thought that the unhandled event must end up there at some point).

I'm glad that you fixed the real root cause of the bug now. Who knows, maybe that might have caused even more bugs in the future. Thanks again, feel free to push to 4.9.

- Frank Reininghaus


On Sept. 26, 2012, 12:53 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106569/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 12:53 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Description
> -------
> 
> This patch fixes a bug where pressing CTRL+Tab does not switch tabs when active tab in Konqueror is a Dolphin's filemanagement part. It happens because DolphinView installs an event filter and does not call event->ignore() or event->setAccepted(false) to allow those events to be propagated up the event chain.
> 
> 
> This addresses bug 302329.
>     http://bugs.kde.org/show_bug.cgi?id=302329
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp 54a8cbf 
> 
> Diff: http://git.reviewboard.kde.org/r/106569/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120926/6218e677/attachment.htm>