Review Request: Fixes the autoactivation bug in folders and places panel

[Emmanuel Pescosta]

> On Sept. 12, 2012, 5:36 p.m., Commit Hook wrote:
> > This review has been submitted with commit 9ab8bcd6aa3ce5d96ee380d5f22d77c2f0a38881 by Emmanuel Pescosta to branch master.
> 
> Frank Reininghaus wrote:
>     I see that you've pushed this to master only. From my point of view, it's a very safe change that you can push to 4.9 as well. Would be nice to have one more bug fixed in KDE 4.9.2 :-)

done ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106381/#review18908
-----------------------------------------------------------


On Sept. 12, 2012, 4:44 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106381/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2012, 4:44 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fixes Bug 305783 - dragging a file over a directory
>      does not expand the dir => Bug discovered: When you drag a
>      item onto a folder-view-item and then move it away
>      instantly before the autoactivation event is triggered
>      (After 750ms), the folder will be opened anyway.
> 
> Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve origin
> 
> I have divided the old review request 106271 into smaller patches.
> 
> Comment #3 from review 106271:
> > a) We never had any complaints about this inconsistency AFAIK. Note that bug 293200 is about something else. The bug description is very difficult to understand, look at Peter's comment 3 for a summary of what we consider to be 
> > the buggy behaviour.
> 
> I think this patch should fix this buggy behaviour ;)
> 
> 
> This addresses bug 305783.
>     http://bugs.kde.org/show_bug.cgi?id=305783
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
> 
> Diff: http://git.reviewboard.kde.org/r/106381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120925/dca12952/attachment.htm>