Review Request: Fix Bug 295573 - Cannot expand directories in folder panel by double-clicking

[Frank Reininghaus]

> On Sept. 19, 2012, 12:41 p.m., Frank Reininghaus wrote:
> > dolphin/src/panels/folders/folderspanel.cpp, line 144
> > <http://git.reviewboard.kde.org/r/106497/diff/1/?file=86159#file86159line144>
> >
> >     I think one reference to the bug report is enough, I would remove the comment in this line.
> 
> Emmanuel Pescosta wrote:
>     Should I commit it to 4.9?

Yes! In general, 4.9 is the right branch for bug fixes, unless the patch is very intrusive, such that there is a certain risk that it may cause regressions. In such cases, I would say explicitly that master is the only right place for the commit.

Thanks again for your awesome work! It's good to see that the Places and Folders Panels will have a couple annoying bugs less in KDE 4.9.2 :-)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106497/#review19159
-----------------------------------------------------------


On Sept. 18, 2012, 6:49 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106497/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 6:49 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Restore old behavior: Navigating by double-clicking in folder panel (Double-Click - show folder content and expand folder)
> 
> 
> This addresses bug 295573.
>     http://bugs.kde.org/show_bug.cgi?id=295573
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.h a881526 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 8795481 
>   dolphin/src/panels/folders/folderspanel.cpp 0760200 
> 
> Diff: http://git.reviewboard.kde.org/r/106497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120920/70765326/attachment.htm>