Review Request: Fix Bug 297355 - Dolphin leaves file preview tooltips open even when is not visible

[Frank Reininghaus]

> On Sept. 19, 2012, 3:29 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! Looks good, but to be sure, I'd like to be able to reproduce the bug to make sure that the patch really does fix the root cause. So I'm asking: what do you have to do to make Qt send a WindowDeactivate event?
> 
> Emmanuel Pescosta wrote:
>     > what do you have to do to make Qt send a WindowDeactivate event?
>     
>     Open Dolphin and another application. When you move from Dolphin to the other application, the WindowDeactivate event will be triggered because Dolphin loses focus. 
>     
>     I think this should fix the strange preview tool tip behavior, because the tool tip widget will be closed when Dolphin loses focus.
>     
>     I tested it with a small debug line ;)
>     if (event->type() == QEvent::WindowDeactivate) {
>       qDebug() << "window deactivate event triggered";
>       hideToolTip();
>     }

Yes, I had expected something like that ;-) It's just that the tool tip always disappears here, even without your patch, when I try that. Maybe one needs some combination of settings to get this bug.

Anyway, I trust your analysis, so please go ahead and push to the 4.9 branch. Thanks!


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106499/#review19164
-----------------------------------------------------------


On Sept. 18, 2012, 8:06 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106499/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 8:06 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 297355 - Dolphin leaves file preview tooltips open even when is not visible
> 
> Hide tool-tip when Dolphin window loses focus.
> 
> 
> This addresses bug 297355.
>     http://bugs.kde.org/show_bug.cgi?id=297355
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.h 3f71fdc 
>   dolphin/src/views/dolphinview.cpp 20edd61 
> 
> Diff: http://git.reviewboard.kde.org/r/106499/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120920/e94cfe2f/attachment.htm>