Review Request: Fixes Bug 293200 - Drag&drop files in dolphin doesn't preserve origin

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106452/
-----------------------------------------------------------

(Updated Sept. 18, 2012, 5:35 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Changed the code according to Franks little suggestions ;) 


Description
-------

Fixes Bug 293200 - Drag&drop files in dolphin doesn't preserve origin

Patch 106381 Comment #3:
When "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel:

1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state.
2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal.

The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel.


This addresses bug 293200.
    http://bugs.kde.org/show_bug.cgi?id=293200


Diffs (updated)
-----

  dolphin/src/kitemviews/kitemlistcontroller.h a881526 
  dolphin/src/kitemviews/kitemlistcontroller.cpp 8795481 
  dolphin/src/panels/folders/folderspanel.cpp 0760200 

Diff: http://git.reviewboard.kde.org/r/106452/diff/


Testing
-------


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120918/3cf6ab2a/attachment.htm>