Review Request: Fixes the autoactivation bug in folders and places panel

[Frank Reininghaus]

> On Sept. 12, 2012, 10:51 a.m., Frank Reininghaus wrote:
> > Thanks for the patch, and sorry for not replying earlier! Looks good, please commit (after removing the whitespace, shown in red in ReviewBoard).
> > 
> > But as far as I can see this will fix only bug 305783, I don't see how this would prevent bug 293200 - at least what Peter describes in comment 3. Note that the mouse is still over the item ~/Images/x in the Folders Panel when the unexpected URL change in the DolphinView happens, so the "m_view->isUnderMouse()" check cannot really do anything about that, I think. Bug 293200 is probably not straigtforward to fix, we'd need to enable automatic expansion, but disable automatic item activation in the Folders Panel...
> > 
> > But this is just the impression I got when looking at your patch. I forgot to test it at home yesterday, and here at university where I build Dolphin on top of the pre-installed KDE 4.7 using some hacks in the CMake file, the Folders Panel is the only part of Dolphin that does not work.
> 
> Emmanuel Pescosta wrote:
>     > after removing the whitespace, shown in red in ReviewBoard
>     Sorry I have forgotten to enable "Remove trailing spaces" in KDevelop.
>     
>     > I don't see how this would prevent bug 293200 - at least what Peter describes in comment 3
>     Ok this bug is not fixed by this commit.
>     But the strange behavior demonstrated in comment 5 (youtube video) is fixed. I can't reproduce this bug anymore :)
>     
>     > we'd need to enable automatic expansion, but disable automatic item activation in the Folders Panel...
>     Let me get this right:
>     + Open folders during drag operations disabled -> Only Auto-Expansion?
>     + Open folders during drag operations enabled -> Auto-Expansion + Open selected folder?

>> I don't see how this would prevent bug 293200 - at least what Peter describes in comment 3
> Ok this bug is not fixed by this commit.
> But the strange behavior demonstrated in comment 5 (youtube video) is fixed. I can't reproduce this bug anymore :)

The YouTube video actually shows a combination of both bugs - first bug 305783 (folders get expanded even though the mouse pointer is not hovering the panel any more) and then the combination of this issue and bug 293200: folder gets opened in the view after hovering the folder in the panel (bug 293200), but when the mouse pointer does not hover the panel any longer (bug 305783).

>> we'd need to enable automatic expansion, but disable automatic item activation in the Folders Panel...
> Let me get this right:
> + Open folders during drag operations disabled -> Only Auto-Expansion?
> + Open folders during drag operations enabled -> Auto-Expansion + Open selected folder?

What I meant was the following: when "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel:

1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state.
2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal.

The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel. But I think there is no good and elegant way to fix that. A fix would probably require to add some complexity and ugliness to the code.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106381/#review18894
-----------------------------------------------------------


On Sept. 12, 2012, 4:44 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106381/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2012, 4:44 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fixes Bug 305783 - dragging a file over a directory
>      does not expand the dir => Bug discovered: When you drag a
>      item onto a folder-view-item and then move it away
>      instantly before the autoactivation event is triggered
>      (After 750ms), the folder will be opened anyway.
> 
> Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve origin
> 
> I have divided the old review request 106271 into smaller patches.
> 
> Comment #3 from review 106271:
> > a) We never had any complaints about this inconsistency AFAIK. Note that bug 293200 is about something else. The bug description is very difficult to understand, look at Peter's comment 3 for a summary of what we consider to be 
> > the buggy behaviour.
> 
> I think this patch should fix this buggy behaviour ;)
> 
> 
> This addresses bug 305783.
>     http://bugs.kde.org/show_bug.cgi?id=305783
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
> 
> Diff: http://git.reviewboard.kde.org/r/106381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120912/54098b24/attachment.htm>