Review Request: Fixes Bug 242007 - "Open Folder during Drag operation" cannot go into different partition using "Places Panel"

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106380/#review18792
-----------------------------------------------------------


Thanks, looks good! Just two small remarks:

1. I think you could make it simpler by only adding the readSettings() slot to the Places Panel. The slot doesn't do anything in the other panels, so the connections are not really necessary.
2. There is some trailing whitespace (marked in red in ReviewBoard) which should be removed.

If you agree (in particular with 1) and fix these issues, please go ahead and push to master. If you don't agree, let me know and we can discuss this. Thanks again for your help!

- Frank Reininghaus


On Sept. 8, 2012, 6:38 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106380/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2012, 6:38 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Open Places (mount devices and partitions) during drag operation.
> 
> 
> This addresses bug 242007.
>     http://bugs.kde.org/show_bug.cgi?id=242007
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h ab79fb0 
>   dolphin/src/dolphinmainwindow.cpp d83c9de 
>   dolphin/src/panels/panel.h 064e1f3 
>   dolphin/src/panels/panel.cpp c2681ec 
>   dolphin/src/panels/places/placespanel.h 8a84e00 
>   dolphin/src/panels/places/placespanel.cpp d445088 
> 
> Diff: http://git.reviewboard.kde.org/r/106380/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120910/656d59f1/attachment.htm>