Review Request: Bug 176277 - dolphin should mount umounted device, if a file is dropped upon its icon in "Places"

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106072/#review18790
-----------------------------------------------------------

Ship it!


Thanks, looks nice! It's a bit more complicated than your first approach, but IMHO that's better than risking crashes :-)

I think that this is safe to commit to the 4.9 branch because the new code path is only taken in the case that the device is not mounted, such that the drag&drop operation fails currently. In the long term, one could think about possibilites to reduce code duplication, but this should include a review of all places where DragAndDropHelper is used and is not urgent at the moment.

- Frank Reininghaus


On Sept. 8, 2012, 6:32 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106072/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2012, 6:32 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Mount unmounted devices, when a file is dropped upon it in places-panel.
> 
> 
> This addresses bug 176277.
>     http://bugs.kde.org/show_bug.cgi?id=176277
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.h 8a84e00 
>   dolphin/src/panels/places/placespanel.cpp d445088 
> 
> Diff: http://git.reviewboard.kde.org/r/106072/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120910/113ea607/attachment.htm>