Review Request: Implementation of KPart listing notification extension for Dolphin

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106333/#review18657
-----------------------------------------------------------


This review has been submitted with commit bfddfa873326eb5577dd1f50098fb40127326644 by Dawit Alemayehu to branch master.

- Commit Hook


On Sept. 6, 2012, 6:52 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106333/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 6:52 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Description
> -------
> 
> The following patch implements the new KParts listing notification extension in Dolphin. This implementation does not add new signals to KFileItemModel and DolphinView classes as the previous solution. Instead it relies on the QObject's introspection to look for KDirLister and connect to the desired signals. 
> 
> This solution is based on the "hack" that was originally implemented in the directory listern plugin. However, unlike that implementation, this one will not suffer from sudden and unexpected changes in Dolphin's code changes because it is closer to the source and it looks for the directory lister directly in KFileItemModel. This is something that cannot be done at the plugin level because it would require the plugin to link against dolphin.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinpart.h f9c0bbf 
>   dolphin/src/dolphinpart.cpp bf3d2a5 
>   dolphin/src/kitemviews/kfileitemmodel.h 958fa10 
>   dolphin/src/views/dolphinview.h 3f08c44 
> 
> Diff: http://git.reviewboard.kde.org/r/106333/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120907/1f7705d0/attachment.htm>