Review Request: Fix for bug 300248

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106325/#review18548
-----------------------------------------------------------

Ship it!


Looks good, thanks! I'll push this the next time I'm at my home computer and have some spare time.

> I'd also like to try another change but I will need some help. Is there a place we can discuss this or can I just send you a mail?

Just send a message to kfm-devel at kde.org, we can discuss any questions concerning Dolphin's source code there.

- Frank Reininghaus


On Sept. 5, 2012, 12:22 p.m., Panos Kanavos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106325/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2012, 12:22 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Provides a possible improvement to Dolphin's additional search criteria button, according to the request in https://bugs.kde.org/show_bug.cgi?id=300248.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchbox.h ee9987a 
>   dolphin/src/search/dolphinsearchbox.cpp 28f1f1a 
> 
> Diff: http://git.reviewboard.kde.org/r/106325/diff/
> 
> 
> Testing
> -------
> 
> The modified button behaves at it should.
> 
> 
> Thanks,
> 
> Panos Kanavos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120905/21a6dde5/attachment.htm>