Review Request: Implementation of KParts listing filter extension for Dolphin

Dawit Alemayehu adawit at kde.org
Wed Sep 5 14:24:57 BST 2012



> On Sept. 5, 2012, 9:27 a.m., Frank Reininghaus wrote:
> > Thanks for your understanding and for the new patch, looks good from my point of view! Maybe I'll check at some point if this can be optimised in master by sharing more code between setMimeTypeFilters() and setNameFilter(), but in the stable branch, it's better not to change the existing code too much. You can push to 4.9 after fixing the little issues below.

Ooops... I guess I posted an earlier version of the patch. :( I have already factored out the common code in those two functions. Except for part that sets the filters, they share the same exact code. Anyhow, I will post that version of the patch along with the changes for the minor issues you raised.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106289/#review18542
-----------------------------------------------------------


On Sept. 4, 2012, 8:01 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106289/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2012, 8:01 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Description
> -------
> 
> The attached patch provides an implementation of KParts' ListingFilterExtension for Dolphin. The extension allows the Dolphin KPart to provide directory/file filtering services without requiring direct linking against Dolphin itself.
> 
> The review for the new KPart listing filter extension (ListingFilterExtension) can be found at https://git.reviewboard.kde.org/r/106288/
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kfileitemmodelfilter.h 9bdf1fd 
>   dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp 816d356 
>   dolphin/src/views/dolphinview.h 10f63c5 
>   dolphin/src/views/dolphinview.cpp 8050415 
>   dolphin/src/kitemviews/kfileitemmodel.h d9bebdf 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 6936af4 
>   dolphin/src/dolphinpart.h e5693b3 
>   dolphin/src/dolphinpart.cpp fff7dc0 
> 
> Diff: http://git.reviewboard.kde.org/r/106289/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120905/8ba17bf7/attachment.htm>


More information about the kfm-devel mailing list