Review Request: Fix for bug 300248

[Panos Kanavos]

> On Sept. 4, 2012, 1:34 p.m., Kai Uwe Broulik wrote:
> > I think "Details" is not an appopriate term. Something like "Refine Search" or so.
> > Note that this can only go into 4.10 due to i18n restrictions in the current branch.
> > (Frank: How can I btw filter for files by keywords? this functionality is mising from the old search sidebar)

Initially I put exactly the title you propose:). Problem is there isn't a suitable and short "opposite" phrase for the pressed button's title. Maybe "More Options" and "Less Options"?


- Panos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106325/#review18503
-----------------------------------------------------------


On Sept. 4, 2012, 1:27 p.m., Panos Kanavos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106325/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2012, 1:27 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Provides a possible improvement to Dolphin's additional search criteria button, according to the request in https://bugs.kde.org/show_bug.cgi?id=300248.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchbox.h ee9987a 
>   dolphin/src/search/dolphinsearchbox.cpp 28f1f1a 
> 
> Diff: http://git.reviewboard.kde.org/r/106325/diff/
> 
> 
> Testing
> -------
> 
> The modified button behaves at it should.
> 
> 
> Thanks,
> 
> Panos Kanavos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120904/25ea27f9/attachment.htm>