Review Request: Fix Bug 294445 - Renaming currently viewed folder in Folders sidebar doesn't update main area

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107070/
-----------------------------------------------------------

(Updated Oct. 31, 2012, 7:29 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Removed clearFocus()

Disconnect signals after usage (With the old method "disconnect before usage in editRole()" the bug reappeared, because of the clearFocus() removal)


Description
-------

Fix Bug 294445 - Renaming currently viewed folder in Folders sidebar doesn't update main area

Especially the error, while renaming a folder in the folderview panel. (Error-dialog appears when you rename the same folder several times)


Question:

void KItemListView::editRole(int index, const QByteArray& role)
{
    KItemListWidget* widget = m_visibleItems.value(index);
    if (!widget || m_editingRole) {
        return;
    }

    m_editingRole = true;
    widget->setEditedRole(role);

    connect(widget, SIGNAL(roleEditingCanceled(int,QByteArray,QVariant)),
            this, SLOT(slotRoleEditingCanceled(int,QByteArray,QVariant)));
    connect(widget, SIGNAL(roleEditingFinished(int,QByteArray,QVariant)),
            this, SLOT(slotRoleEditingFinished(int,QByteArray,QVariant)));
}

Should we disconnect the signals roleEditingCanceled and roleEditingFinished from KItemListWidget* widget, before we connect the signals? When you rename the same folder/file several times, the slots are called multiple times ...

1. Rename -> 1 Slot call
2. Rename -> 2 Slot calls
3. Rename -> 3 Slot calls 
...

Solution:

widget->disconnect(SIGNAL(roleEditingCanceled(int,QByteArray,QVariant), this);
widget->disconnect(SIGNAL(roleEditingFinished(int,QByteArray,QVariant), this);


This addresses bugs 294445 and 309338.
    http://bugs.kde.org/show_bug.cgi?id=294445
    http://bugs.kde.org/show_bug.cgi?id=309338


Diffs (updated)
-----

  dolphin/src/kitemviews/kitemlistview.h 5723b9a 
  dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 

Diff: http://git.reviewboard.kde.org/r/107070/diff/


Testing
-------

Renaming a folder in the folderview-panel works without problems. 


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121031/abeb9089/attachment.htm>