Review Request: Fix Bug 279333 - Panels can be moved even if locked

Frank Reininghaus frank78ac at googlemail.com
Tue Oct 30 22:03:14 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107135/#review21180
-----------------------------------------------------------

Ship it!


OK, I see, thanks for the nice screenshots! In that case, I can confirm that your patch fixes the issue, please push to 4.9!

- Frank Reininghaus


On Oct. 30, 2012, 9:41 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107135/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 9:41 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 279333 - Panels can be moved even if locked
> 
> 
> This addresses bug 279333.
>     http://bugs.kde.org/show_bug.cgi?id=279333
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphindockwidget.cpp 72e06a6 
> 
> Diff: http://git.reviewboard.kde.org/r/107135/diff/
> 
> 
> Testing
> -------
> 
> Panel can not be moved, if the panel layout is locked.
> 
> 
> Screenshots
> -----------
> 
> Panel layout is locked but you can drag around panels, when you press your mouse in the red area
>   http://git.reviewboard.kde.org/r/107135/s/804/
> "Locked" panel fail
>   http://git.reviewboard.kde.org/r/107135/s/805/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121030/a852bd34/attachment.htm>


More information about the kfm-devel mailing list