Review Request: Fix Bug 153984 - Clicking cancel on the authentication dialog for fish/sftp/ftp kioslave gets dolphin stuck on "Loading folder"

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107116/#review21112
-----------------------------------------------------------


Thanks Emmanuel, it's good to see that this issue finally gets fixed :-)

For consistency with other error messages, I would suggest to not show the error in the status bar, but in the KMessageWidget - can simply be done by calling the DolphinViewContainer's showErrorMessage(const QString& msg) method. When you change this, you can just push to master from my point of view :-) (in principle, we could ask the translators if it's OK to ship this in the next 4.9.x release, but given that the bug has been there for quite some time and that we're quickly approaching KDE 4.10, I think that's not so urgent).

Just for the record: I first thought that this could also be done with a lot less code by just making the KFileItemModel emit errorMessage(const QString&) and directoryLoadingCompleted(), but in the end I came to the conclusion that your approach is better because completing and canceling are conceptually different things.

- Frank Reininghaus


On Oct. 29, 2012, 3:12 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107116/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 3:12 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 153984 - Clicking cancel on the authentication dialog for fish/sftp/ftp kioslave gets dolphin stuck on "Loading folder"
> 
> 
> This addresses bug 153984.
>     http://bugs.kde.org/show_bug.cgi?id=153984
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h 8a0309b 
>   dolphin/src/dolphinviewcontainer.cpp 8a566cf 
>   dolphin/src/kitemviews/kfileitemmodel.h 5bcebce 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 61f512a 
>   dolphin/src/views/dolphinview.h 7d8e8b7 
>   dolphin/src/views/dolphinview.cpp 9051d98 
> 
> Diff: http://git.reviewboard.kde.org/r/107116/diff/
> 
> 
> Testing
> -------
> 
> Works with sftp, ftp and fish.
> 
> When you press cancel, the progressbar disappears and the status message "Directory loading has been canceled." is displayed.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121029/4d7d4080/attachment.htm>