Review Request: Extended/Completed Frank's commit 7ca682fe903d6abfc44e2f26878e19ddc48b5633

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107072/#review21053
-----------------------------------------------------------

Ship it!


Thanks Emmanuel! This was still on my list of things that need to be done before the hard feature freeze - it's awesome that you took care of it! I'd change the checkbox text to just "Rename inline" (the same text that was used in KDE <= 4.7), but the rest is good as it is - please push to master!

- Frank Reininghaus


On Oct. 27, 2012, 2:05 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107072/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2012, 2:05 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Extended/Completed Frank's commit 7ca682fe903d6abfc44e2f26878e19ddc48b5633.
> 
> * Implemented Rename-Inline-Option in Settings Dialog
> * Re-enable renaming items with the rename dialog in Folderview-Panel
> 
> 
> This addresses bug 306705.
>     http://bugs.kde.org/show_bug.cgi?id=306705
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/folders/folderspanel.cpp 13093ff 
>   dolphin/src/settings/general/behaviorsettingspage.h 3989862 
>   dolphin/src/settings/general/behaviorsettingspage.cpp 1ade93c 
> 
> Diff: http://git.reviewboard.kde.org/r/107072/diff/
> 
> 
> Testing
> -------
> 
> Rename-Dialog works for Folderview-Panel
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121028/d9948e38/attachment.htm>