Review Request: Implemented multithreading in KFileItemModelSortAlgorithm

[Emmanuel Pescosta]

> On Oct. 28, 2012, 4:15 p.m., Frank Reininghaus wrote:
> > Thanks, looks perfect now! Feel free to push it to master. I'm sure that the users will appreciate this improvement, in particular those who have 4 or more 'real' CPU cores.
> 
> Mark Gaiser wrote:
>     Please wait with this patch since my efforts in making a collating cache might make sorting an insanely fast since all sorting logic (which is done right now in every iteration) will then be moved out of the sort algorithm. That one will just do int comparisons and will be a _lot_ faster. I'm actually waiting for some additional eyes to look at it since i have a small issue i'm hitting...
> 
> Frank Reininghaus wrote:
>     Any further speed-ups will of course be welcome :-) But I really don't see why your efforts are a reason not to push Emmanuel's patch.
> 
> Emmanuel Pescosta wrote:
>     Hmm sorry, I already pushed it to master. Bad timing ...

> Any further speed-ups will of course be welcome :-) But I really don't see why your efforts are a reason not to push Emmanuel's patch.
Ok :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107025/#review21045
-----------------------------------------------------------


On Oct. 26, 2012, 7:17 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107025/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 7:17 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Implemented multithreading in KFileItemModelSortAlgorithm.
> 
> If more than 100 items to sort and ideal thread count is greater than 1 -> sort them with parallelSort (2 Threads)
> 
> Use maximal 2 Threads, because more than 2 Threads are "slower" (more overhead than speed up). (I also have a patch which uses n Threads for sorting, if you want test it ;)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 3a596df 
>   dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp e0aac13 
> 
> Diff: http://git.reviewboard.kde.org/r/107025/diff/
> 
> 
> Testing
> -------
> 
> About 2 seconds faster with sorting 500.000 files.
> About 5 seconds faster with sorting 1.000.000 files.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121028/620b2db6/attachment.htm>