Review Request: Use QPixmapCache for KStandardItemListWidget::pixmapForIcon

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Thu Oct 25 16:43:14 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107039/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.


Description
-------

Use QPixmapCache for KStandardItemListWidget::pixmapForIcon(const QString& name, int size) -> Avoid KIcon loading and rescaleing


Diffs
-----

  dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf 

Diff: http://git.reviewboard.kde.org/r/107039/diff/


Testing
-------

According to valgrind/callgrind lesser cpu time and according to valgrind/massif lesser memory consume


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121025/cb0bbc27/attachment.htm>


More information about the kfm-devel mailing list